Skip to content

Commit 0ffa696

Browse files
authored
Merge pull request #1124 from aashu2006/fix/oscillator-constructor-bug
Fix missing p5. prefix in Simple Melody App tutorial
2 parents c23b4e3 + c559ed3 commit 0ffa696

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/content/tutorials/en/getting-started-with-nodejs.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ Object i
225225
// ...prototype
226226
```
227227

228-
Now you are ready to build the [Melody App](https://docs.google.com/document/u/0/d/1mzJv-7qU1_CmkWI0ZFeqf3CeBfpOOVIrvPRZtxqFxRI/edit)! You can access completed code for this guide in [this Github repository](https://github.com/MsQCompSci/melodyAppNodeStarter/tree/main).
228+
Now you are ready to build the [Melody App](./simple-melody-app)! You can access completed code for this guide in [this Github repository](https://github.com/MsQCompSci/melodyAppNodeStarter/tree/main).
229229

230230

231231
## Next Steps

src/content/tutorials/en/optimizing-webgl-sketches.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ Try making a swarm of bugs, flock of birds, or school of fish by making a `p5.Ge
431431

432432
There are many effects one can achieve that involve looking at and modifying individual pixels on the canvas. Unfortunately, modifying `pixels` in your sketch involves looping through every pixel, one at a time, in JavaScript. A shader, on the other hand, can run in parallel for every pixel at once, making it a great alternative for when speed is required.
433433

434-
Here is an example of some noise-based dithering using `pixels`, and the equivalent filter using a shader. Be sure to check out our [introduction to shaders](https://docs.google.com/document/u/0/d/1R7eO9XHcACHnxanFCKVviBK2c1Pci0y9qfRwuHY2_PI/edit) for more information about shader programming.
434+
Here is an example of some noise-based dithering using `pixels`, and the equivalent filter using a shader. Be sure to check out our [introduction to shaders](./intro-to-shaders) for more information about shader programming.
435435

436436
<Columns>
437437
<Column>

src/content/tutorials/en/simple-melody-app.mdx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ If you are already familiar with:
5454
- [periodic waves and their characteristics](#periodic-wave-characteristics)
5555
- [musical notes (frequency, pitch, and amplitude)](#musical-notes)
5656

57-
Skip to [Play musical notes with oscillators](https://docs.google.com/document/d/1mzJv-7qU1_CmkWI0ZFeqf3CeBfpOOVIrvPRZtxqFxRI/edit#heading=h.xqocsbtmp68w) to bypass background knowledge.
57+
Skip to [Play musical notes with oscillators](#play-musical-notes-with-oscillators) to bypass background knowledge.
5858

5959

6060
## Oscillators, science & music background information
@@ -68,18 +68,18 @@ To understand how oscillators generate musical notes, we can dive into some scie
6868

6969
##### Note
7070

71-
In the next section, [Science of sound and music](https://docs.google.com/document/d/1mzJv-7qU1_CmkWI0ZFeqf3CeBfpOOVIrvPRZtxqFxRI/edit#bookmark=id.xmj3wil8257x), the following concepts are introduced:
71+
In the next section, [Science of sound and music](#science-of-sound--music), the following concepts are introduced:
7272

7373
- [Sound as a pressure waves](https://www.physicsclassroom.com/class/sound/u11l1c.cfm)
74-
- [Periodic wave characteristics](https://docs.google.com/document/d/1mzJv-7qU1_CmkWI0ZFeqf3CeBfpOOVIrvPRZtxqFxRI/edit#heading=h.p80snea79dfs)
74+
- [Periodic wave characteristics](#periodic-wave-characteristics)
7575
- [Sound waves](https://www.open.edu/openlearn/science-maths-technology/engineering-technology/sound-music-technology-an-introduction/content-section-2.3) in relation to musical notes
7676
- [Pitch and frequency](https://www.physicsclassroom.com/class/sound/Lesson-2/Pitch-and-Frequency)
7777
- Music Theory concepts such a [melodies](https://www.masterclass.com/articles/music-101-what-is-melody), [musical notes & frequency](https://www.idrumtune.com/ultimate-guide-to-musical-frequencies/) 
7878

7979

8080
##### Skip ahead 
8181

82-
If you are already familiar with the background concepts above, jump over to the [Building a melody app](https://docs.google.com/document/d/1mzJv-7qU1_CmkWI0ZFeqf3CeBfpOOVIrvPRZtxqFxRI/edit#heading=h.xqocsbtmp68w) section to begin your project! 
82+
If you are already familiar with the background concepts above, jump over to the [Building a melody app](#build-simple-app) section to begin your project! 
8383

8484

8585
## Science of sound & music 
@@ -165,7 +165,7 @@ The **frequency** of sound waves can be heard through its tones, or pitch, which
165165
Visit the [Sound Synthesis Tutorial from The Coding Train](https://www.youtube.com/watch?app=desktop\&v=Bk8rLzzSink) for a brief introduction to p5.Oscillator objects and waves.
166166

167167

168-
## Play musical notes with osciallators
168+
## Play musical notes with oscillators
169169

170170
Let’s dive into the wonderful world of sound, music and oscillators to create a [simple melody app](https://editor.p5js.org/Msqcoding/sketches/w_4t5bFYe)
171171

@@ -295,7 +295,7 @@ let myFreq = 262;
295295
function setup() {
296296
  createCanvas(400, 400);
297297
  // Create the Oscillator object.
298-
  osc = new Oscillator(myFreq);
298+
  osc = new p5.Oscillator(myFreq);
299299
  // console.log(osc.f);
300300
}
301301

0 commit comments

Comments
 (0)