Skip to content

refactor(channel): remove unused pushName field#2460

Open
vduggen wants to merge 2 commits intoEvolutionAPI:developfrom
vduggen:find-chats-pushName
Open

refactor(channel): remove unused pushName field#2460
vduggen wants to merge 2 commits intoEvolutionAPI:developfrom
vduggen:find-chats-pushName

Conversation

@vduggen
Copy link

@vduggen vduggen commented Mar 4, 2026

📋 Description

This PR updates the chat listing query to ensure that the pushName always reflects the contact’s name, not the name from the last message sender.

Previously, in the PostgreSQL fetchChats query, the pushName for non-group chats was calculated using COALESCE("Contact"."pushName", "Message"."pushName"). This could lead to incorrect results: when the last message was sent by someone else (e.g., in a multi-participant context), the pushName would show the sender’s name instead of the contact’s name. The query has been updated so that, for non-group chats, pushName now uses only "Contact"."pushName", preventing it from being overridden by "Message"."pushName" and ensuring consistent, contact-based naming.

🔗 Related Issue

Closes #(issue_number)

🧪 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧹 Code cleanup
  • 🔒 Security fix

🧪 Testing

  • Manual testing completed
  • Functionality verified in development environment
  • No breaking changes introduced
  • Tested with different connection types (if applicable)

Testing details:

  • Verified that chats where the last message was sent by another user no longer display that user’s name as pushName, but instead correctly show the contact’s pushName.
  • Confirmed that existing chats with a valid Contact.pushName keep the same visible name.
  • Ensured the overall chat listing query still returns the expected structure and ordering.

📸 Screenshots (if applicable)

✅ Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have manually tested my changes thoroughly
  • I have verified the changes work with different scenarios
  • Any dependent changes have been merged and published

📝 Additional Notes

  • This change aligns the pushName behavior with the expectation that it always represents the contact’s name in chat lists, avoiding confusion when the last message is sent by someone else.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes a redundant selection of the pushName field from a channel query so that the value computed earlier in the query is no longer incorrectly overridden with Chat.name, preventing null/incorrect pushName results.

File-Level Changes

Change Details Files
Stop overriding the correctly derived pushName value with Chat.name in the channel startup query.
  • Removed the later SELECT projection of pushName sourced from Chat.name so only the earlier, correctly computed pushName is returned
  • Kept all other selected fields and query structure unchanged to preserve existing behavior and API contract
src/api/services/channel.service.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant