Conversation
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
# Conflicts: # frontend/web/components/pages/UserPage.tsx
Member
Author
|
Ok! all refactored and no typescript errors exist that relate to permissions |
# Conflicts: # frontend/common/providers/Permission.tsx # frontend/package-lock.json # frontend/package.json # frontend/web/components/feature-summary/FeatureRow.tsx # frontend/web/components/modals/FlagValueFooter.tsx # frontend/web/components/modals/create-feature/FeatureLimitAlert.tsx # frontend/web/components/modals/create-feature/index.js # frontend/web/components/modals/create-feature/tabs/CreateFeature.tsx # frontend/web/components/modals/create-feature/tabs/FeatureSettings.tsx # frontend/web/components/modals/create-feature/tabs/FeatureValue.tsx # frontend/web/components/mv/VariationOptions.tsx # frontend/web/components/navigation/navbars/ProjectNavbar.tsx # frontend/web/components/pages/FeaturesPage.js
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
How did you test this code?
E2E, checking each usage of permission
Note: due to amount of refactoring I've done, I've pointed this to the latest branch I've been working on