feat: add on this day from wiki#121
Merged
yammesicka merged 18 commits intoPythonFreeCourse:developfrom Feb 7, 2021
Merged
Conversation
Gonzom
reviewed
Jan 23, 2021
Codecov Report
@@ Coverage Diff @@
## develop #121 +/- ##
===========================================
- Coverage 99.38% 99.11% -0.27%
===========================================
Files 37 35 -2
Lines 1456 1362 -94
===========================================
- Hits 1447 1350 -97
- Misses 9 12 +3
Continue to review full report at Codecov.
|
ivarshav
reviewed
Jan 23, 2021
yammesicka
requested changes
Jan 24, 2021
…into feat/ellen/on-this-day
Contributor
Author
|
@yammesicka You totaly right, i changed the base branch to develop and added db cashing. pls review again :) |
yammesicka
reviewed
Jan 31, 2021
Member
yammesicka
left a comment
There was a problem hiding this comment.
Awesome job on this one! Please add tests to insert_on_this_day_data and get_on_this_day_events
yammesicka
requested changes
Feb 2, 2021
…into feat/ellen/on-this-day
Contributor
Author
|
passed the tests! |
yammesicka
reviewed
Feb 4, 2021
Member
yammesicka
left a comment
There was a problem hiding this comment.
Great job! Just another little push
…into feat/ellen/on-this-day
yammesicka
approved these changes
Feb 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
you can see it in the last card in profile page :)