Feature/event patterns#127
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #127 +/- ##
===========================================
+ Coverage 99.29% 99.30% +0.01%
===========================================
Files 41 41
Lines 1691 1739 +48
===========================================
+ Hits 1679 1727 +48
Misses 12 12
Continue to review full report at Codecov.
|
yammesicka
left a comment
There was a problem hiding this comment.
Great job, almost finished :)
30bc4fc to
d020366
Compare
yammesicka
left a comment
There was a problem hiding this comment.
Great job, I've added few notes :)
app/internal/event.py
Outdated
| all_regular_invitees_concatenated = '' | ||
| for record in similar_events_invitees: | ||
| if record: | ||
| all_regular_invitees_concatenated += ',' + record[0] |
There was a problem hiding this comment.
You join it and then split it. Can you make it more efficient? :)
There was a problem hiding this comment.
I don't see how I can do that without changing the models
There was a problem hiding this comment.
Just add a variable called regular_invitees before the for loop, and use regular_invitees.add(record[0]) each iteration
…into feature/event-patterns
…into feature/event-patterns
app/internal/event.py
Outdated
| all_regular_invitees_concatenated = '' | ||
| for record in similar_events_invitees: | ||
| if record: | ||
| all_regular_invitees_concatenated += ',' + record[0] |
There was a problem hiding this comment.
Just add a variable called regular_invitees before the for loop, and use regular_invitees.add(record[0]) each iteration
depends on #126