Merged
Conversation
This feature includes the core functions added to /internal, English and Hebrew json files, removal of text strings from the html files, updates to the routes and model updates. Also included are tests. Please note, that this feature is waiting on user registration for final hooks.
… move foreignkey to last column as requested in CR. Additional minor doc fixes.
This change hopefully adds this line to the code coverage.
This change reduces the amount of imports needed and also uses one dir path for both tests and live.
… and "localized" and the creation of the Jinja2TemplateResponse is now handled in internal/utilities.
The translations are now handled with @lru_cache and the function is only re-handled when a new language code parameter is used. This should be the last edit (unless any crash) to this version of the translation feature.
Changed i18n system as requested in code review.
Fixed missing curly parenthesis in profile.html Changed _get_supported_languages() into a generator expression Merged testing parameters in test_language.py
Contributor
Author
|
@yammesicka this wasn't merged last time. Please merge this before the other PR or that PR probably won't work. |
Reduce the if statement by using the _get_language_directory() as the default value instead of None.
yammesicka
approved these changes
Feb 5, 2021
Codecov Report
@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
+ Coverage 99.22% 99.23% +0.01%
===========================================
Files 40 41 +1
Lines 1546 1576 +30
===========================================
+ Hits 1534 1564 +30
Misses 12 12
Continue to review full report at Codecov.
|
Member
|
The code has some failing tests :( |
# Conflicts: # app/main.py # requirements.txt
# Conflicts: # app/main.py # requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23