Frontend Inheritance Organization (WIP) - Calendar Responsiveness Bug Fix#218
Merged
yammesicka merged 8 commits intoPythonFreeCourse:developfrom Feb 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #218 +/- ##
========================================
Coverage 99.38% 99.38%
========================================
Files 37 37
Lines 1456 1456
========================================
Hits 1447 1447
Misses 9 9
Continue to review full report at Codecov.
|
aviadamar
reviewed
Feb 6, 2021
yammesicka
requested changes
Feb 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered a bug in responsiveness that makes the calendar not stretch till the bottom of the browser.
Fixed using some flex/grid magic and changed the scroll listener to be on #calendar-grid instead of the of the whole window.
Also rearranged some files and made better template bases.
Pushing so @aviadamar can continue. Hopefully didn't break anything 🤞