[Theme] Add replace() to build proper encoded URL#6800
Open
Ashpabb wants to merge 1 commit intoSemantic-Org:masterfrom
Open
[Theme] Add replace() to build proper encoded URL#6800Ashpabb wants to merge 1 commit intoSemantic-Org:masterfrom
Ashpabb wants to merge 1 commit intoSemantic-Org:masterfrom
Conversation
In the case of a font with spaces in the name (e.g. Roboto Slab), the import url will not be valid and fonts will not load as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Firefox and in the case where a font has spaces in the name (e.g. Roboto Slab), the import url for Google Fonts will not be valid and fonts may not load as expected.