[Build Tools] Fixes docs build error from Node's fs#6853
Open
whoisryosuke wants to merge 1 commit intoSemantic-Org:masterfrom
Open
[Build Tools] Fixes docs build error from Node's fs#6853whoisryosuke wants to merge 1 commit intoSemantic-Org:masterfrom
whoisryosuke wants to merge 1 commit intoSemantic-Org:masterfrom
Conversation
`fs` from Node now requires a callback for the third parameter, which was missing from the docs Gulp build task file, causing the `gulp build-docs` process to break with the following error:
```
[15:59:18] Starting 'build-docs'...
Building Metadata
Copying examples
Copying LESS source
Building Semantic for docs
(node:72733) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
fs.js:113
throw err; // Forgot a callback but don't know where? Use NODE_DEBUG=fs
^
Error: ENOENT: no such file or directory, open '/Users/username/Development/HTML/docs/out/metadata.json'
ITs-MacBook-Pro-6:ksc-ui photoroom$ ./node_modules/gulp/bin/gulp.js build-docs
```
Adding a simple error callback (with optional console log for error reporting) **fixes this issue**. Running the docs build process now works.
Not sure if this has already been hashed out for the next release cycle.
RedhatPH8
approved these changes
Dec 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building docs is broken. This fixes it.
npm igulp build-docsand received error.fsfrom Node now requires a callback for the third parameter, which was missing from the docs Gulp build task file, causing thegulp build-docsprocess to break with the following error:Adding a simple error callback (with optional console log for error reporting) fixes this issue. Running the docs build process now works.
Not sure if this has already been hashed out for the next release cycle.