Add macOS global package crawling fallbacks and pyenv support#34
Merged
mikolalysenko merged 1 commit intomainfrom Mar 5, 2026
Merged
Add macOS global package crawling fallbacks and pyenv support#34mikolalysenko merged 1 commit intomainfrom
mikolalysenko merged 1 commit intomainfrom
Conversation
NPM crawler: add find_node_dirs_sync() helper and macOS fallback paths (Homebrew, nvm, volta, fnm) with deduplication in get_global_node_modules_paths(). Python crawler: add pyenv site-packages discovery via PYENV_ROOT. E2E tests: add macOS auto-discovery smoke tests for npm and pypi. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_node_dirs_sync()synchronous wildcard resolver and macOS fallback paths (Homebrew ARM/Intel, nvm, volta, fnm) withHashSetdeduplication inget_global_node_modules_paths()site-packagesdiscovery viaPYENV_ROOTenv var (fallback$HOME/.pyenv) on macOS and Linux#[cfg(target_os = "macos")]auto-discovery smoke tests for both npm and pypi that runscan -g --jsonwithout--global-prefixTest plan
cargo test -p socket-patch-core --features cargo— 260 tests pass (7 new)cargo test --features cargo— full suite passes, no regressionscargo test -p socket-patch-cli --test e2e_npm -- --ignored test_npm_macos— macOS npm e2ecargo test -p socket-patch-cli --test e2e_pypi -- --ignored test_pypi_macos— macOS pypi e2e🤖 Generated with Claude Code