fix(db): throw error when fn.select() is used with groupBy()#1324
Open
fix(db): throw error when fn.select() is used with groupBy()#1324
Conversation
fn.select() with groupBy() silently produced wrong results ({ __key_0: ... })
because the compiler cannot statically analyze an opaque function to discover
aggregate expressions needed by groupBy. This adds a clear error message
directing users to use the standard .select() API instead.
Closes #1189
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e60aa76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: +157 B (+0.17%) Total Size: 92.8 kB
ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.85 kB ℹ️ View Unchanged
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fn.select()combined withgroupBy()silently produced wrong results (only{ __key_0: ... }instead of the expected computed fields) becauseprocessGroupBy()receivedundefinedforselectClausegroupByneeds to statically analyze the SELECT clause to discover aggregate functions (count,sum,max, etc.), which is not possible withfn.select()since it's an opaque JavaScript functionFnSelectWithGroupByErrorthat throws a clear error message directing users to use the standard.select()API insteadCloses #1189
Test plan
fn.select()+groupBy()throwsFnSelectWithGroupByError🤖 Generated with Claude Code