Added classical implementation of Shor’s Algorithm#12545
Closed
adityakrmishra wants to merge 2 commits intoTheAlgorithms:masterfrom
Closed
Added classical implementation of Shor’s Algorithm#12545adityakrmishra wants to merge 2 commits intoTheAlgorithms:masterfrom
adityakrmishra wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
- Implemented a classical simulation of Shor’s Algorithm in `algorithms/cryptography/shor_algorithm.py` - The algorithm factors a composite number N without using quantum computing libraries - Uses modular exponentiation and order-finding to determine factors - Includes an example usage for testing
for more information, see https://pre-commit.ci
lulunac27a
suggested changes
Feb 13, 2025
|
|
||
| def gcd(a, b): | ||
| """Computes the greatest common divisor using Euclidean algorithm.""" | ||
| while b: |
There was a problem hiding this comment.
This line should be while b == 0:, not while b: to make sure b is zero.
shivam28082002
approved these changes
Feb 15, 2025
shivam28082002
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
algorithms/cryptography/shor_algorithm.pyDescribe your change:
Summary
This PR adds a classical implementation of Shor’s Algorithm to the
cryptographymodule. The algorithm factors a given composite numberNby:amoduloNNChanges
shor_algorithm.pyinalgorithms/cryptography/Issue Reference
Closes #12318
Testing
Possible Improvements
tests/cryptography/test_shor_algorithm.pyLooking forward to feedback! 🚀