fix: add actual link check step to sphinx_build_link_check.sh#286
Open
NucleiAv wants to merge 1 commit intoaboutcode-org:mainfrom
Open
fix: add actual link check step to sphinx_build_link_check.sh#286NucleiAv wants to merge 1 commit intoaboutcode-org:mainfrom
NucleiAv wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
The script was named sphinx_build_link_check and commented as 'Build locally, and then check links' but only ran the HTML build step. This adds the missing `sphinx-build -b linkcheck` command to actually check links as intended. Fixes aboutcode-org#284 Signed-off-by: newklei <magmacicada@proton.me>
6cd2875 to
3af70ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284
The script was named sphinx_build_link_check and commented as "Build locally, and then check links" but only ran the HTML build step. Adds the missing sphinx-build -b linkcheck command.