Skip to content

Fix Deprecation Warning in timeutils.py and archive.py (#75) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
utkarshasinha wants to merge 2 commits into from
Closed

Fix Deprecation Warning in timeutils.py and archive.py (#75) #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee46e6
Fix DeprecationWarning in timeutils.py and archive.py (#75)
utkarshasinha Feb 16, 2026
ada9f45
Fix timezone-aware datetime compatibility in timeutils.py
utkarshasinha Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/commoncode/archive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ def extract_tar(location, target_dir, verbatim=False, filter=None, *args, **kwar
if py314 and filter:
tar.extractall(target_dir, members=to_extract, filter=filter)
else:
tar.extractall(target_dir, members=to_extract)
try:
tar.extractall(target_dir, members=to_extract, filter='data')
except TypeError:
tar.extractall(target_dir, members=to_extract)
finally:
if tar:
tar.close()
Expand Down
3 changes: 2 additions & 1 deletion src/commoncode/timeutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#

from datetime import datetime
from datetime import timezone
from datetime import tzinfo
from functools import update_wrapper
from functools import wraps
Expand Down Expand Up @@ -58,7 +59,7 @@ def time2tstamp(dt=None, path_safe=True):
to convert back to a datetime object.
"""
# TODO: check that the dt is effectively in UTC
datim = dt or datetime.utcnow()
datim = dt or datetime.now(timezone.utc).replace(tzinfo=None)
iso = datim.isoformat()
if path_safe:
iso = iso.replace(":", "").replace("/", "_")
Expand Down
Loading