Conversation
3736d5d to
6e9e08e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5389 +/- ##
=======================================
Coverage 60.54% 60.54%
=======================================
Files 138 138
Lines 13672 13672
=======================================
Hits 8278 8278
Misses 4690 4690
Partials 704 704
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest Buf updates on your PR. Results from workflow Proto Push / proto-push (pull_request).
|
9a4e2aa to
98955d2
Compare
| breaking_against: "https://github.com/${GITHUB_REPOSITORY}.git#branch=v2" | ||
| breaking_against: "https://github.com/${{ github.repository }}.git#branch=v2,subdir=rpc" | ||
|
|
||
| # TODO: we need to version the protos for pushing |
There was a problem hiding this comment.
do we still need to do this so it doesnt overwrite the v1 protos?
There was a problem hiding this comment.
The documentation is a bit missing some parts in Buf
I see there’s a main label(tag/branch). I’m wondering if it would be possible to also have a v2 label(tag/branch), similar to how it’s done on GitHub. That would be nice and would allow both versions to be maintained.
There was a problem hiding this comment.
i'll look into this in the AM
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
No description provided.