Fix 132 tags not found by wellDan28 · Pull Request #136 · github-tools/github-release-notes

wellDan28 · 2018-02-19T09:17:52Z

Close #132

The resolution contains two parts:

Enable pagination when two tags were provided in the tags option
Validate that the two tags were found (if they were provided)

getLastTags should use pagination when the tag option were set to 2 tags and these tags weren not found yet

codecov-io · 2018-02-19T09:21:26Z

Codecov Report

Merging #136 into master will decrease coverage by 47.05%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master     #136       +/-   ##
===========================================
- Coverage   85.75%   38.69%   -47.06%     
===========================================
  Files           7        7               
  Lines         316      323        +7     
===========================================
- Hits          271      125      -146     
- Misses         45      198      +153

Impacted Files	Coverage Δ
lib/src/Gren.js	`5.69% <0%> (-78.18%)`	⬇️
lib/src/GitHubInfo.js	`80.95% <0%> (-4.77%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e6b2e4...78762a5. Read the comment docs.

ignoreTagsWith should work only when tags=all

wellDan28 · 2018-02-20T06:43:22Z

@alexcanessa I don't understand why the codevcov tests are failing, do you have any clue?

alexcanessa · 2018-02-20T12:58:03Z

@wellDan28 I'm trying to understand.

alexcanessa

@wellDan28 don't worry for the codecov, it's going to automatically get fixed when master runs.

alexcanessa · 2018-02-21T10:59:59Z

lib/src/Gren.js

+    _validateRequiredTagsExists(tags, requireTags) {
+        if (requireTags.indexOf('all') >= 0 || !(requireTags instanceof Array)) return;
+
+        const tagsNames = tags.map(x => x.tag.name);


Please use explicit parameters name (i.e. tagData instead of x)

alexcanessa · 2018-02-21T11:02:38Z

lib/src/Gren.js

+        if (missingTags.length > 0) {
+            const notFoundMessage = (missingTags.length === 1) ? 'tag is' : 'tags are';
+            throw chalk.red(`\nThe following ${notFoundMessage} not found in the repository: ${missingTags}. ` +
+                'please provider tags that are exists in the repository');


Why not everything in the template literal?

I'm sorry, I don't understand, could you please explain what you mean?

alexcanessa · 2018-02-21T11:07:21Z

lib/src/Gren.js

+        if (missingTags.length > 0) {
+            const notFoundMessage = (missingTags.length === 1) ? 'tag is' : 'tags are';
+            throw chalk.red(`\nThe following ${notFoundMessage} not found in the repository: ${missingTags}. ` +
+                'please provider tags that are exists in the repository');


Please change so that:

~~please provider tags that are exists in the repository~~ please provide existing tags.

alexcanessa

@wellDan28 last feedback, promise 👍

alexcanessa · 2018-02-21T11:44:03Z

lib/src/Gren.js

+
+        const missingTags = requireTags.filter(requireTag => tagsNames.indexOf(requireTag) < 0);
+        if (missingTags.length > 0) {
+            const notFoundMessage = (missingTags.length === 1) ? 'tag is' : 'tags are';


~~notFoundMessage~~ to inflection as it makes more sense 👍

alexcanessa · 2018-02-21T11:51:15Z

lib/src/Gren.js

+     * Check that the require tags are exists in tags
+     *
+     * @param {Array} tags
+     * @param {any} requireTags


You can expect requireTags to be Array because this.options.tags it's always an Array

github-release-notes/lib/src/_utils.js

Lines 123 to 149 in 3e6b2e4

/**

* Converts an array like string to an actual Array,

* converting also underscores to spaces

*

* @since 0.6.0

* @public

*

* @param {string} arrayLike The string of items

* e.g.

* "wont_fix, duplicate, bug"

*

* @return {Array} The items with spaces instead of underscores.

*/

function convertStringToArray(arrayLike) {

if (!arrayLike) {

return [];

}

if (typeof arrayLike === 'object') {

return Object.keys(arrayLike).map((itemKey) => arrayLike[itemKey]);

}

return arrayLike

.replace(/\s/g, '')

.split(',')

.map((itemName) => itemName.replace(/_/g, ' ', itemName));

}

Also, replace the @return with @throws as the function is only returning undefined

alexcanessa · 2018-02-21T11:51:39Z

lib/src/Gren.js

+        if (missingTags.length > 0) {
+            const notFoundMessage = (missingTags.length === 1) ? 'tag is' : 'tags are';
+            throw chalk.red(`\nThe following ${notFoundMessage} not found in the repository: ${missingTags}. ` +
+                'please provide existing tags.');


Why not one template literal?

alexcanessa · 2019-12-12T16:53:19Z

@all-contributors please add @wellDan28 for bug

allcontributors · 2019-12-12T16:53:27Z

@alexcanessa

I've put up a pull request to add @wellDan28! 🎉

alexcanessa · 2019-12-12T17:10:10Z

@all-contributors please add @wellDan28 for code

allcontributors · 2019-12-12T17:10:18Z

@alexcanessa

I've put up a pull request to add @wellDan28! 🎉

wellDan28 added 2 commits February 19, 2018 08:28

Fix pagination should work for two specific tags

2c8c40e

getLastTags should use pagination when the tag option were set to 2 tags and these tags weren not found yet

Add validation - check that the tags option are found

e34e94f

Fix - requireTags contains 'all clause'

2cf0c71

wellDan28 mentioned this pull request Feb 19, 2018

Tags not found #132

Closed

wellDan28 added 2 commits February 20, 2018 08:24

Fix test

472f355

ignoreTagsWith should work only when tags=all

Add tests fot _validateRequiredTagsExists method

114a733

alexcanessa requested changes Feb 21, 2018

View reviewed changes

wellDan28 added 2 commits February 21, 2018 13:20

Rename paramters names

6111590

Change the exception message

cb44386

alexcanessa requested changes Feb 21, 2018

View reviewed changes

wellDan28 added 2 commits February 21, 2018 14:21

Change const name

d8ff54d

Improve the documention to '_validateRequiredTagsExists'

78762a5

alexcanessa merged commit adfc5e5 into github-tools:master Feb 21, 2018

wellDan28 mentioned this pull request Apr 3, 2018

Tags not found - bug #156

Closed

allcontributors bot mentioned this pull request Dec 12, 2019

docs: add wellDan28 as a contributor #233

Merged

allcontributors bot mentioned this pull request Dec 12, 2019

docs: add wellDan28 as a contributor #239

Merged

	/**
	* Converts an array like string to an actual Array,
	* converting also underscores to spaces
	*
	* @since 0.6.0
	* @public
	*
	* @param {string} arrayLike The string of items
	* e.g.
	* "wont_fix, duplicate, bug"
	*
	* @return {Array} The items with spaces instead of underscores.
	*/
	function convertStringToArray(arrayLike) {
	if (!arrayLike) {
	return [];
	}

	if (typeof arrayLike === 'object') {
	return Object.keys(arrayLike).map((itemKey) => arrayLike[itemKey]);
	}

	return arrayLike
	.replace(/\s/g, '')
	.split(',')
	.map((itemName) => itemName.replace(/_/g, ' ', itemName));
	}

Conversation

wellDan28 commented Feb 19, 2018

Uh oh!

codecov-io commented Feb 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wellDan28 commented Feb 20, 2018

Uh oh!

alexcanessa commented Feb 20, 2018

Uh oh!

alexcanessa left a comment

Choose a reason for hiding this comment

Uh oh!

alexcanessa Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

alexcanessa Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

wellDan28 Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

alexcanessa Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

alexcanessa left a comment

Choose a reason for hiding this comment

Uh oh!

alexcanessa Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

alexcanessa Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

alexcanessa Feb 21, 2018

Choose a reason for hiding this comment

Uh oh!

alexcanessa commented Dec 12, 2019

Uh oh!

allcontributors bot commented Dec 12, 2019

Uh oh!

alexcanessa commented Dec 12, 2019

Uh oh!

allcontributors bot commented Dec 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Feb 19, 2018 •

edited

Loading