Specify releases of the CodeQL Action using tags instead of branches#1033
Merged
henrymercer merged 6 commits intomainfrom Apr 25, 2022
Merged
Specify releases of the CodeQL Action using tags instead of branches#1033henrymercer merged 6 commits intomainfrom
henrymercer merged 6 commits intomainfrom
Conversation
Prepare for renaming `v1` -> `releases/v1` and `v2` -> `releases/v2`.
aeisenberg
approved these changes
Apr 14, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
This looks great. I'm pretty sure you mentioned that it's not ready to be merged until later, but it looks good to be merged when that time comes.
Contributor
Author
|
I intend to merge this after updating the |
This was referenced Apr 27, 2022
This was referenced Apr 25, 2023
This was referenced Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently reference versions of the CodeQL Action (
v1,v2) using branches and not tags. This is nice because it is more consistent with the intention of tags in Git. However it is problematic in terms of Dependabot: users on thev1orv2branches won't get Dependabot update PRs, as these are only generated for users on a specific tag or commit SHA.This PR prepares us to specify releases of the CodeQL Action using tags instead of branches, which will mean our customers who have configured Dependabot for the Actions ecosystem configured will receive a Dependabot update from
v1tov2.Commit-by-commit review recommended. I'd particularly appreciate a check that I haven't forgot to update any places that use the release branches (i.e. previously
v1andv2, nowreleases/v1andreleases/v2).Deployment plan
v1andv2toreleases/v1andreleases/v2respectively. This PR will also automatically update thev1andv2tags as part of future release processes. (This is that PR.)releases/v1andreleases/v2v1andv2tags manuallyv1andv2branches toreleases/v1andreleases/v2respectivelyExample Dependabot update on a private repo backlinked for maintainers.
Merge / deployment checklist