Merged
Conversation
b8e27d7 to
f86f601
Compare
Also, this cleans up our pack-related integration tests. We are now testing with the most recent CLIs.
f86f601 to
06b15c2
Compare
cklin
approved these changes
Apr 29, 2022
|
|
||
| # use tr to replace newlines with spaces and xargs to trim leading and trailing whitespace | ||
| RULES="$(cat javascript.sarif | jq -r '.runs[0].results[].ruleId' | sort | tr "\n" " " | xargs)" | ||
| RULES="$(cat javascript.sarif | jq -r '.runs[0].results[].ruleId' | sort | tr "\n" " " | tr "\r" " " | xargs)" |
Contributor
There was a problem hiding this comment.
I think this also works (first character of string1 maps to first character of string2, and the second to the second, and so on):
tr "\r\n" " "
Contributor
Author
There was a problem hiding this comment.
Oh...didn't know tr worked that way. Thanks.
Contributor
Author
|
I'm about to make a minor change to this PR and I will ask for another review. Thanks for looking. |
This will allow the command to resolve packs with paths. Also, use a more concise version of `tr`.
0120296 to
a73e506
Compare
Contributor
Author
|
Note that some required checks have been removed and that's why this is not mergeable. I am going to remove these as required checks and then recreate the list of required as described here: https://github.com/github/codeql-core/issues/1405#issuecomment-896190163 I'll make sure these instructions are easier to find. |
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, use newer versions of the integration test packs that allow us to run with the latest CLI.
There are a few things of note here:
Merge / deployment checklist