Merged
Conversation
adityasharad
approved these changes
May 9, 2022
| echo "Updating v1" | ||
| gh api --silent -X "PATCH" repos/github/codeql-action/branches/releases/v1/protection/required_status_checks --input checks.json | ||
|
|
||
| rm check.json |
Contributor
There was a problem hiding this comment.
Suggested change
| rm check.json | |
| rm checks.json |
Comment on lines
+26
to
+31
| echo "Updating main" | ||
| gh api --silent -X "PATCH" repos/github/codeql-action/branches/main/protection/required_status_checks --input checks.json | ||
| echo "Updating v2" | ||
| gh api --silent -X "PATCH" repos/github/codeql-action/branches/releases/v2/protection/required_status_checks --input checks.json | ||
| echo "Updating v1" | ||
| gh api --silent -X "PATCH" repos/github/codeql-action/branches/releases/v1/protection/required_status_checks --input checks.json |
Contributor
There was a problem hiding this comment.
You could do this in a loop:
for BRANCH in main releases/v2 releases/v1; do
...
done| # Update the required checks based on the current branch. | ||
| # Typically, this will be main. | ||
|
|
||
| # NOTE: This script can only be run by someone with admin rights on this repo. |
Contributor
There was a problem hiding this comment.
As a quick failsafe in the script, you can check whether GITHUB_TOKEN is non-empty. Otherwise the first call to gh api will pause and ask for user login.
65b476d to
0fa3d09
Compare
This also removes the .github/workflows/update-required-checks.yml workflow. This script needs to be run locally by someone who has admin privileges on the repo.
0fa3d09 to
827fd55
Compare
Contributor
|
@aeisenberg Could we update the |
6 tasks
Contributor
Author
|
Sure...I'll take care of that in another PR. |
This was referenced May 11, 2022
This was referenced Apr 25, 2023
This was referenced Apr 27, 2023
This was referenced Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes the .github/workflows/update-required-checks.yml
workflow. This script needs to be run locally by someone who has
admin privileges on the repo.