Add Swift as a possible traced language#1085
Conversation
|
There are lots of other places we'll need to update as well. Take a look at And, it's probably going to be necessary to add the At some point (now is probably too early), we're going to want an integration test for swift. Someone on our team can help with that. |
|
Thanks for the comments, Andrew! I should have written what my goal with this PR was: We'd like to get Swift support on DCA as soon as possible so that we can monitor extractor and QL performance. If we could get this PR merged onto
It was enough to get past the "Unsupported language: Swift" error I was getting when trying to get DCA working for Swift. Here's a run that shows that it working: https://github.com/dsp-testing/codeql-dca-worker/actions/runs/2414815040.
Yes, definitely. For now, we're injecting the If you're concerned about this PR not being "complete" before we merge it we can make this PR a draft and continue to use its SHA as a custom checkout for DCA. |
aeisenberg
left a comment
There was a problem hiding this comment.
Thanks for clarifying your goal. I think it's fine to get this in so that the narrow use case of DCA is working. We'll need to revisit this later.
Merge / deployment checklist