Merged
Conversation
612ac0e to
8f89ee5
Compare
c6893e6 to
76ea1ff
Compare
76ea1ff to
abb2f8a
Compare
This decorator enabled us to use the functionality of the Actions toolcache within the runner too. Now that we've deleted the runner we no longer need it.
41e985e to
9eed356
Compare
9eed356 to
a73b38a
Compare
aeisenberg
reviewed
Jun 29, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
This looks sensible. I just have a few questions inline so I can understand what is going on.
Comment on lines
+66
to
+68
| // Workaround an issue in tests where the case insensitivity of the `$PATH` | ||
| // environment variable on Windows isn't preserved, i.e. `process.env.PATH` | ||
| // is not the same as `process.env.Path`. |
Contributor
There was a problem hiding this comment.
That's wild. When does this happen?
Contributor
Author
There was a problem hiding this comment.
I spent a while looking into this, but couldn't track down what was going on. My suspicion is that this weirdness might have something to do with how we use an assignment to process.env to reset it at the end of every test to its value at the start of the test.
`toolcache.extractTar` currently falls over when `ACTIONS_TEMP` contains a symlink, and the runner no longer exists, so it's unlikely our customers would be running with temporary directories that contain symlinks.
a73b38a to
130a51d
Compare
aeisenberg
approved these changes
Jun 29, 2022
9953936 to
b1742f8
Compare
aeisenberg
approved these changes
Jul 11, 2022
This was referenced Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs our unit tests on Windows, primarily to improve test coverage but also to support developing the Action on Windows machines. In doing so, we fix a couple of bugs.
For review: I spent a while looking at whether we could avoid the ugly hack in 6063828, however couldn't find anything. Do you have any thoughts?
Based on #1104.
Merge / deployment checklist