Skip to content

Don't crash if we are unable to get a response from the feature-flag endpoint.#1145

Merged
criemen merged 3 commits intomainfrom
criemen/fix-ff-crash
Jul 18, 2022
Merged

Don't crash if we are unable to get a response from the feature-flag endpoint.#1145
criemen merged 3 commits intomainfrom
criemen/fix-ff-crash

Conversation

@criemen
Copy link
Contributor

@criemen criemen commented Jul 18, 2022

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@criemen criemen requested a review from a team as a code owner July 18, 2022 10:15
@criemen criemen enabled auto-merge July 18, 2022 10:20
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions but otherwise looks good.

@criemen criemen disabled auto-merge July 18, 2022 10:37
@criemen criemen requested a review from henrymercer July 18, 2022 10:37
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@criemen criemen enabled auto-merge July 18, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants