Round fields in TRAP caching telemetry to integers#1188
Merged
edoardopirovano merged 1 commit intomainfrom Aug 17, 2022
Merged
Conversation
henrymercer
approved these changes
Aug 17, 2022
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
I think keeping them as ints makes sense since it's consistent with the other duration metrics like analyze_builtin_queries_cpp_duration_ms.
| config.trapCaches, | ||
| logger | ||
| trap_cache_upload_duration_ms: Math.round(trapCacheUploadTime || 0), | ||
| trap_cache_upload_size_bytes: Math.round( |
Contributor
There was a problem hiding this comment.
You could optionally push the rounding in here, if you'll only need the rounded values.
Contributor
Author
There was a problem hiding this comment.
Hmm, yes, I considered doing that but decided that rounding at the point where we construct the status report was the safest way to make sure we only send an integer to the API. Let's leave it like this for now to unbreak things, and we can always shuffle this around at some other point.
6 tasks
This was referenced Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status reporting API expects these to be integers.
Merge / deployment checklist