Add changelog note for Go extraction reconciliation by angelapwen · Pull Request #1286 · github/codeql-action

angelapwen · 2022-10-06T17:43:05Z

Merge / deployment checklist

Confirm this change is backwards compatible with existing workflows.
Confirm the readme has been updated if necessary.
Confirm the changelog has been updated if necessary.

henrymercer

Some small recommendations

CHANGELOG.md

Co-authored-by: Henry Mercer <henrymercer@github.com>

CHANGELOG.md

henrymercer

Further tweaks from Slack

henrymercer · 2022-10-06T19:47:28Z

CHANGELOG.md

 ## [UNRELEASED]

-No user facing changes.
+- We will soon be rolling out a feature of the CodeQL Action that changes the way that Go code is analyzed to be more consistent with other compiled languages. You do not need to change your code scanning workflows. If you encounter any problems, please [file an issue](https://github.com/github/codeql-action/issues) or open a private ticket with GitHub Support and request an escalation to engineering.


Suggested change

- We will soon be rolling out a feature of the CodeQL Action that changes the way that Go code is analyzed to be more consistent with other compiled languages. You do not need to change your code scanning workflows. If you encounter any problems, please [file an issue](https://github.com/github/codeql-action/issues) or open a private ticket with GitHub Support and request an escalation to engineering.

- We will be rolling out a feature of the CodeQL Action in October 2022 that changes the way that Go code is analyzed to be more consistent with other compiled languages like C/C++, C#, and Java. You do not need to change your code scanning workflows. If you encounter any problems, please [file an issue](https://github.com/github/codeql-action/issues) or open a private ticket with GitHub Support and request an escalation to engineering.

Oops, I committed Andrew's suggestion and can't auto-commit this one anymore from the UI. Will push it up locally.

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>

angelapwen · 2022-10-06T19:55:33Z

Need another non-stale ✅ from @henrymercer or @aeisenberg 🙏

* Update changelog and version after v2.1.26 * Update checked-in dependencies * Don't check for Go logs on failure (#1279) * Update supported GitHub Enterprise Server versions. (#1275) Co-authored-by: GitHub <noreply@github.com> * TRAP Caching: Add timeouts to upload/download operations * Add logging statements declaring state of the cli_config_file_enabled It's possible to determine this otherwise, but this makes it easier to spot. * Avoid using single value as array The user config parser in the CLI doesn't yet support it. * Extract logging statements to separate function * Correctly report CodeQL version when using cache (#1259) * Correctly report CodeQL version when using cache * Add JS generated files * Add test for return value of `setupCodeQL` * Fill in missing return value comment * Convert "Invalid source root" errors to UserErrors * Add changelog note for Go extraction reconciliation (#1286) * Add changelog note for Go extraction reconciliation * Update CHANGELOG.md Co-authored-by: Henry Mercer <henrymercer@github.com> * Update CHANGELOG.md Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> * Tweaks from PR review Co-authored-by: Henry Mercer <henrymercer@github.com> Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> * Update changelog for v2.1.27 Co-authored-by: github-actions[bot] <github-actions@github.com> Co-authored-by: Chuan-kai Lin <cklin@github.com> Co-authored-by: Angela P Wen <angelapwen@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Edoardo Pirovano <edoardo.pirovano@gmail.com> Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com> Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> Co-authored-by: Henry Mercer <henrymercer@github.com>

* Merge main into releases/v2 (#1287) * Update changelog and version after v2.1.26 * Update checked-in dependencies * Don't check for Go logs on failure (#1279) * Update supported GitHub Enterprise Server versions. (#1275) Co-authored-by: GitHub <noreply@github.com> * TRAP Caching: Add timeouts to upload/download operations * Add logging statements declaring state of the cli_config_file_enabled It's possible to determine this otherwise, but this makes it easier to spot. * Avoid using single value as array The user config parser in the CLI doesn't yet support it. * Extract logging statements to separate function * Correctly report CodeQL version when using cache (#1259) * Correctly report CodeQL version when using cache * Add JS generated files * Add test for return value of `setupCodeQL` * Fill in missing return value comment * Convert "Invalid source root" errors to UserErrors * Add changelog note for Go extraction reconciliation (#1286) * Add changelog note for Go extraction reconciliation * Update CHANGELOG.md Co-authored-by: Henry Mercer <henrymercer@github.com> * Update CHANGELOG.md Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> * Tweaks from PR review Co-authored-by: Henry Mercer <henrymercer@github.com> Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> * Update changelog for v2.1.27 Co-authored-by: github-actions[bot] <github-actions@github.com> Co-authored-by: Chuan-kai Lin <cklin@github.com> Co-authored-by: Angela P Wen <angelapwen@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Edoardo Pirovano <edoardo.pirovano@gmail.com> Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com> Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> Co-authored-by: Henry Mercer <henrymercer@github.com> * Update changelog and version after v2.1.27 * Update checked-in dependencies Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions@github.com> Co-authored-by: Chuan-kai Lin <cklin@github.com> Co-authored-by: Angela P Wen <angelapwen@github.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Edoardo Pirovano <edoardo.pirovano@gmail.com> Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com> Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> Co-authored-by: Henry Mercer <henrymercer@github.com>

Add changelog note for Go extraction reconciliation

93c16c0

angelapwen requested a review from a team as a code owner October 6, 2022 17:43

angelapwen requested a review from henrymercer October 6, 2022 17:44

henrymercer previously approved these changes Oct 6, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

angelapwen dismissed henrymercer’s stale review via 8a3c292 October 6, 2022 19:36

Update CHANGELOG.md

8a3c292

Co-authored-by: Henry Mercer <henrymercer@github.com>

angelapwen requested a review from henrymercer October 6, 2022 19:36

aeisenberg reviewed Oct 6, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

henrymercer previously approved these changes Oct 6, 2022

View reviewed changes

angelapwen dismissed henrymercer’s stale review via 73bcf3f October 6, 2022 19:52

angelapwen and others added 2 commits October 6, 2022 12:52

Update CHANGELOG.md

73bcf3f

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>

Tweaks from PR review

dd71945

aeisenberg approved these changes Oct 6, 2022

View reviewed changes

angelapwen enabled auto-merge (squash) October 6, 2022 21:18

angelapwen merged commit e4cc4a2 into main Oct 6, 2022

angelapwen deleted the angelapwen/changelog-go branch October 6, 2022 22:18

github-actions bot mentioned this pull request Oct 6, 2022

Merge main into releases/v2 #1287

Merged

7 tasks

github-actions bot mentioned this pull request Oct 14, 2022

Merge main into releases/v2 #1303

Closed

7 tasks

aeisenberg mentioned this pull request Oct 14, 2022

Fix incompatible merge into main #1304

Closed

3 tasks

github-actions bot mentioned this pull request Oct 17, 2022

Merge releases/v2 into releases/v1 #1309

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add changelog note for Go extraction reconciliation#1286

Add changelog note for Go extraction reconciliation#1286
angelapwen merged 4 commits intomainfrom
angelapwen/changelog-go

angelapwen commented Oct 6, 2022

Uh oh!

henrymercer left a comment

Uh oh!

Uh oh!

Uh oh!

henrymercer left a comment

Uh oh!

henrymercer Oct 6, 2022

Uh oh!

angelapwen Oct 6, 2022

Uh oh!

angelapwen commented Oct 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

angelapwen commented Oct 6, 2022

Merge / deployment checklist

Uh oh!

henrymercer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

henrymercer left a comment

Choose a reason for hiding this comment

Uh oh!

henrymercer Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

angelapwen Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

angelapwen commented Oct 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants