Merged
Conversation
aeisenberg
approved these changes
Nov 14, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
I think this will work. Our tests for v1 do not rely on lockfile v2.
This was referenced Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockfile v3 works with npm v7 and later (source). We're currently using npm v8, so we can simplify our lockfiles a bit by updating the lockfile version. Also add an
.npmrcspecifying which lockfile version to use, such that both npm v8 (used for compatibility with checks that run on Node 12) and npm v9 (which contributors might be running on their local machine) will generate v3 lockfiles.Merge / deployment checklist