Read CODE_SCANNING_REF env variable#1368
Merged
aeisenberg merged 1 commit intogithub:mainfrom Nov 15, 2022
marcogario:marcogario/code_scanning_ref
Merged
Read CODE_SCANNING_REF env variable#1368aeisenberg merged 1 commit intogithub:mainfrom marcogario:marcogario/code_scanning_ref
aeisenberg merged 1 commit intogithub:mainfrom
marcogario:marcogario/code_scanning_ref
Conversation
edoardopirovano
approved these changes
Nov 15, 2022
henrymercer
approved these changes
Nov 15, 2022
aeisenberg
approved these changes
Nov 15, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good.
It would be nice if we had a getOptionalEnvVar function for cases like this. But, this is outside the scope of this PR.
This was referenced Nov 16, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on how we trigger the action run, sometimes the GITHUB_REF is not set.
This seems to be a special variable and we are unable to override it in anyway.
The solution we propose here is to have a dedicated extra environment variable that we can consider.
Why not use the existing params: There is a restriction on the existing
refparam that requires theshato be set. This is not something we need (and it is a stronger requirement than we care about). Moreover, when trying to use these parameters we ran into some warning messages so we are not clear on how well supported they are.This is the minimal patch that serves our purpose, please provide feedback on how to shape it better.
Merge / deployment checklist