Merged
Conversation
aeisenberg
reviewed
Nov 23, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Looks like GITHUB_ACTION_REPOSITORY is not being set during the integration tests. See:
https://github.com/github/codeql-action/actions/runs/3532744788/jobs/5927496032#step:4:14
Contributor
|
Otherwise looks reasonable. |
d8597f3 to
bc341c5
Compare
Contributor
Author
|
So I've updated the PR to only remove the code that deals with the fact that GHES 2.22 didn't populate |
aeisenberg
approved these changes
Nov 23, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
LGTM assuming all jobs pass.
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Action requires GHES 3.3, so we can safely remove this fallback logic for GHES 2.22 and GHES 3.0.
Merge / deployment checklist