Hide error message and stack for non-error#1485
Merged
aeisenberg merged 3 commits intomainfrom Jan 18, 2023
Merged
Conversation
Avoid printing the error message and stack when we fail to find the commit. This will happen in several non-error states (e.g., when there is no repository checked out at the CWD). Move the error message to a debug message so that it is still available if someone really wants to see it.
angelapwen
reviewed
Jan 17, 2023
Contributor
Author
|
@angelapwen Thanks for your review. Can you re-approve? |
Co-authored-by: Angela P Wen <angelapwen@github.com>
526c990 to
e6e3bf4
Compare
angelapwen
approved these changes
Jan 18, 2023
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
These changes look unrelated to the CI failures to me — are we failing CI on main?
Contributor
Author
|
Yep. Failing on main. Checking on this now. |
This was referenced Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid printing the error message and stack when we fail to find the commit. This will happen in several non-error states (e.g., when there is no repository checked out at the CWD). Move the error message to a debug message so that it is still available if someone really wants to see it.
Merge / deployment checklist