Merged
Conversation
738afa7 to
0a11e3f
Compare
We should be checking in all contents of the dependencies, including OS junk!
6 tasks
Contributor
Author
|
@github/codeql-action-reviewers This is ready for review. The two checks that are still yellow have been removed, and we'll need to update the required checks prior to merging. |
aeisenberg
reviewed
Jan 19, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nice!
This was really hard to review since the PR tools in the browser just wasn't loading the code for me. Or I had to wait 10-15 seconds for rendering.
aeisenberg
reviewed
Jan 19, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
A few minor comments for typing, but I think it's basically good.
238f8f1 to
67c69d1
Compare
This is no longer needed now that we only release v2
67c69d1 to
4beb395
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've dropped Node 12 support, we can upgrade to the latest version of TypeScript!
Merge / deployment checklist