Add max line length of 120 to linter#1524
Merged
angelapwen merged 2 commits intogithub:mainfrom Feb 7, 2023
Merged
Conversation
aeisenberg
previously approved these changes
Feb 6, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. My understanding is that the linting rules here are copied from gh/gh. I think it's generally ok to become stricter than gh/gh, but not more lenient. So, this PR LGTM.
henrymercer
previously approved these changes
Feb 6, 2023
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
LGTM. Perhaps we can look to remove the ignore* settings as we go forwards, but we should prioritize this alongside re-enabling the rules we disabled while transitioning to eslint at the bottom of the file.
aad52df
7f70608 to
aad52df
Compare
Contributor
Author
|
Had to rebase |
henrymercer
approved these changes
Feb 7, 2023
Comment on lines
+90
to
+91
| /** Whether the relevant tools dotcom feature flags have been misconfigured. | ||
| * Only populated if we attempt to determine the default version based on the dotcom feature flags. */ |
Contributor
There was a problem hiding this comment.
For next time (I don't think this is worth a recompiling and rerunning the checks for)
Suggested change
| /** Whether the relevant tools dotcom feature flags have been misconfigured. | |
| * Only populated if we attempt to determine the default version based on the dotcom feature flags. */ | |
| /** | |
| * Whether the relevant tools dotcom feature flags have been misconfigured. | |
| * Only populated if we attempt to determine the default version based on the dotcom feature flags. */ |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the
max-lenproperty to the linter, which will enforce a maximum of 120 characters per line. It also ignores URLs, strings, and template literals in case these cases exceed 120 characters.We also have the option to ignore all comments, or just trailing comments (https://eslint.org/docs/latest/rules/max-len). I have left those out for now but am open to adding them! The PR also fixes some comments that have exceeded the 120 character limit.
Merge / deployment checklist