Optionally send tools download telemetry#1538
Merged
angelapwen merged 1 commit intogithub:mainfrom Feb 13, 2023
Merged
Conversation
henrymercer
previously approved these changes
Feb 13, 2023
4348b8b to
7f82764
Compare
henrymercer
approved these changes
Feb 13, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sends the two optional telemetry fields
tools_download_duration_msandtools_feature_flags_validconditionally: if either field is undefined, the field is not sent.This should not change anything in our telemetry because the fields should have been ignored regardless, but we add them conditionally just to be sure.
Merge / deployment checklist