Improve paths config handling for JS/Python when globs are used#2061
Improve paths config handling for JS/Python when globs are used#2061
paths config handling for JS/Python when globs are used#2061Conversation
|
I have only tested this change against the Python extractor implementation, where I know the ordering of LGTM_INDEX_FILTER is respected. I assume it would be by the other languages as well, but better be safe 😊 So I want to make an integration test to ensure that with a directory structure as below, a config with or do you rather think that should be part of the tests for the extractors? (let me know what you think) |
|
Thanks for looking into this, this fix looks good. However I think we want to implement it in the CLI rather than the Action. Context: We moved the logic for computing As of today, GHES 3.7 was deprecated, and therefore we've been able to drop support for CodeQL v2.11.5 and earlier in the Action. This means we no longer need to maintain the implementation of this functionality in the Action, and I've put up a PR to remove it here: #2062 Would you mind porting your implementation to the CLI? If not, I'm happy to take this on since it's a small change — let me know! |
|
Makes sense. I'll close this PR then 👍 |
Merge / deployment checklist