Conversation
|
@Daverlo could you review this. I believe you originally wrote these python tests. With these changes, I am not sure if the workflows are still testing the things you are intending them to test. |
|
Was the |
|
Yes...let me remove that. |
The requests module 1.2.3 is no longer compatible with python >=3.10.0. So, instead use 2.26.0, the most recent version that is compatible with our supported python versions at the time of this commit.
1b16d54 to
3df2172
Compare
aibaars
left a comment
There was a problem hiding this comment.
This looks fine to me. I wonder if we could leave the "*" version specifiers unchanged.
|
|
||
| [packages] | ||
| requests = "*" | ||
| requests = "2.26.0" |
There was a problem hiding this comment.
I guess this change could be reverted, hopefully the version from the lock file will be taken.
|
|
||
| [packages] | ||
| requests = "*" | ||
| requests = "2.26.0" |
There was a problem hiding this comment.
I guess this change could be reverted, hopefully the version from the lock file will be taken.
|
|
||
| [packages] | ||
| requests = "*" | ||
| requests = "2.26.0" |
There was a problem hiding this comment.
I guess this change could be reverted, hopefully the version from the lock file will be taken.
| [tool.poetry.dependencies] | ||
| python = "^3.8" | ||
| requests = "*" | ||
| requests = "2.26.0" |
There was a problem hiding this comment.
I guess this change could be reverted, hopefully the version from the lock file will be taken.
| python = "^3.5" | ||
| requests = "*" | ||
| python = "^3.6" | ||
| requests = "2.26.0" |
There was a problem hiding this comment.
I guess this change could be reverted, hopefully the version from the lock file will be taken.
| requests = "2.26.0" | |
| requests = "*" |
Also, rename test scripts to indicate the version they are using.
67eb85e to
43ea2ce
Compare
The requests module 1.2.3 is no longer compatible with python >=3.10.0.
So, instead use 2.26.0, the most recent version that is compatible with
our supported python versions at the time of this commit.
Merge / deployment checklist