Merged
Conversation
b684105 to
9c43038
Compare
95327cd to
829cdb3
Compare
9846f42 to
10b0d81
Compare
d4bb43c to
427ceab
Compare
d3a91ad to
abe8e36
Compare
Bumps [@ava/typescript](https://github.com/avajs/typescript) from 2.0.0 to 3.0.1. - [Release notes](https://github.com/avajs/typescript/releases) - [Commits](avajs/typescript@v2.0.0...v3.0.1) --- updated-dependencies: - dependency-name: "@ava/typescript" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
abe8e36 to
1163942
Compare
3273370 to
ce89f1b
Compare
Contributor
|
@github/codeql-action-reviewers I needed to make some changes to the Action codebase, e.g. adding type annotations, converting macros to use the typed versions, modifying Eslint configuration, to upgrade to AVA 4. Therefore I can't reasonably review this PR myself. Please could one of you take a look? |
aeisenberg
approved these changes
Feb 2, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Thanks for taking this on. Looks good to me.
So, it seems like for ava > 4, a failing assertion does not end the test, which is a nice feature (I think).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @ava/typescript from 2.0.0 to 3.0.1.
Release notes
Sourced from
@ava/typescript's releases.Commits
34da7bf3.0.15b4fac1Actually parse package.json filesfe34dddClarify usage with AVA 3a3b205a3.0.016eeb96Fix branch reference120de3bTest using npm@8a675a67Support ESM files0429a39Update CIc2eb369Match AVA 4 Node.js versionsa3b6326Upgrade to ESMDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)