Merged
Conversation
Mergeback v1.0.27 refs/heads/v1 into main
Turboscan only allows a single combination of tool name and automation details id for testing category uniqueness. Previously, the check in the action was not entirely correct since it only looked at the _category_ and not the combination of the category and the tool name. It's even more precise now since it is looking at the actual, computed value of the automation details id, rather than an inputted value of the category. This change also includes a refactoring where the action is now avoiding multiple parsing/stringifying of the sarif files. Instead, sarif is parsed once at the start of the process and stringified once, after sarif processing is completely finished.
A single SARIF file should be allowed to have duplicated categories.
Update warning about interpreted languages to mention Ruby
Change category uniqueness test
Bump CodeQL version to 2.7.5
CHANGELOG.md
Outdated
|
|
||
| ## 1.0.28 - 18 Jan 2022 | ||
|
|
||
| No user facing changes. |
Contributor
There was a problem hiding this comment.
This doesn't look right. Shouldn't the version bump to 2.7.5 be here?
Contributor
Contributor
It's been 25 hours since the bundle bump was merged, and I haven't noticed any screaming, so 👍 |
hmakholm
approved these changes
Jan 18, 2022
hmakholm
previously requested changes
Jan 18, 2022
CHANGELOG.md
Outdated
|
|
||
| - The `analyze` and `upload-sarif` actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the `wait-for-processing` action input to `"false"`. | ||
|
|
||
| - Update default CodeQL bundle version to 2.7.5. |
Contributor
There was a problem hiding this comment.
Oops, this got mismerged into the wrong section of the changelog when I updated my PR.
IIUC the right procedure is to fix it in this PR and then a mergeback PR will be autogenerated.
Contributor
There was a problem hiding this comment.
I also need to add a change log entry for another feature. So please don't merge until my change is in as well.
Add an entry and move an entry.
53a2f66 to
19970ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging b31df3f into v1
Conductor for this PR is @aeisenberg
Contains the following pull requests:
Please review the following: