Merged
Conversation
And add a better error message. By using `void` instead of `await`, any error thrown is not caught by surrounding try-catch blocks. I could continue to use `void` and explicitly handle any thrown errors by using `.catch`, but most likely the time savings is minimal and this makes the code more complex.
henrymercer
reviewed
Jan 21, 2022
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
I was just looking at this too. Couple of suggestions.
Discussion here #882 (comment) shows that properly handling preloading feature flag errors is complex and the benefit we get from it does not offset the complexity.
Contributor
|
I haven't reviewed the code since Henry seems to have it covered (although happy to if you would like another set of eyes), but could I ask to hold off merging this until Tuesday since it seems like a potentially risky change to put into GHES 3.4 at the last minute? |
Contributor
Author
|
Thanks for the reminder. I don't think this is a required fix for GHES 3.4. I will hold off on the merge. |
henrymercer
approved these changes
Jan 24, 2022
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
A couple of suggestions, otherwise LGTM to get in after the GHES 3.4 release.
Contributor
|
I've done the release that is going into GHES 3.4 so please do not consider this blocked on that anymore 👍🏼 |
20dbc92 to
806fc12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add a better error message.
By using
voidinstead ofawait, any error thrown is not caughtby surrounding try-catch blocks.
I could continue to use
voidand explicitly handle any thrown errorsby using
.catch, but most likely the time savings is minimal andthis makes the code more complex.
Merge / deployment checklist