Merged
Conversation
This commit adds a `UserError` class that should be thrown when the cause of an error is fundamentally from user configuration. When sending status reports, avoid sending a `failure` for `UserError`s. This will prevent our diagnostics from pinging us for errors outside of our control.
Contributor
Author
|
OK...Looks like there may need to be a server-side change as well. Here is an attempt to send a Alternatively, we could send |
edoardopirovano
approved these changes
Feb 22, 2022
Contributor
edoardopirovano
left a comment
There was a problem hiding this comment.
All seems good to me. You'll want to hold off merging till my PR doing the server-side changes is merged, however.
Contributor
|
Server-side changes are done. I'm going to go ahead and merge this. |
Contributor
|
Confirmed a test run looks good: https://github.com/edoardopirovano/actions-test2/runs/5302594964 I can also find the test run in Splunk and it's correctly tagged with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a
UserErrorclass that should be thrown when thecause of an error is fundamentally from user configuration.
When sending status reports, avoid sending a
failureforUserErrors.This will prevent our diagnostics from pinging us for errors outside of
our control.
This particular PR adds two cases where we use
user-errorinstead offailure:initaction twice in one workflow.We can add more cases as we see fit.
Questions for reviewers:
user-error) to our status reports?Merge / deployment checklist