Revert "Merge pull request #869 from github/edoardo/windows-11-error"#948
Revert "Merge pull request #869 from github/edoardo/windows-11-error"#948edoardopirovano merged 1 commit intomainfrom
Conversation
criemen
left a comment
There was a problem hiding this comment.
LGTM from my side (but I'm not an actions reviewer, so maybe get a review from them, too)
henrymercer
left a comment
There was a problem hiding this comment.
Should we continue to raise errors for users using old versions of CodeQL with build tracing that's incompatible with Windows 11?
|
I thought about this, but I don't think it's necessary: |
|
I'm inclined to agree. We already have so many version flags in the Action, if we can avoid adding another one that seems preferable. |
|
Makes sense 👍 |
This reverts commit faa9ba7, reversing changes made to 71112ab.
The last few versions of the CodeQL CLI have emitted errors about tracing incompatibility with Windows 11, so there is no need for the Action to continue to emit these. In addition, the CodeQL CLI will soon be compatible with Windows 11, so if we still had the error here in place when that happens we would be stopping users from using CodeQL on Windows 11 for no good reason.
Merge / deployment checklist