Add runner OS and arch to status report#959
Merged
cklin merged 3 commits intogithub:mainfrom Mar 3, 2022
cklin:report-runner-os-arch
Merged
Add runner OS and arch to status report#959cklin merged 3 commits intogithub:mainfrom cklin:report-runner-os-arch
cklin merged 3 commits intogithub:mainfrom
cklin:report-runner-os-arch
Conversation
aeisenberg
reviewed
Mar 2, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
I'm pretty sure status reports will fail to upload because of the new fields until we can make the server side changes.
aeisenberg
approved these changes
Mar 3, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. Just be sure to get the hydro schema changes deployed before merging this.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
aeisenberg
reviewed
Mar 3, 2022
| statusReport.matrix_vars = matrix; | ||
| } | ||
| if (runnerOs === "Windows" || runnerOs === "macOS") { | ||
| statusReport.runner_os_release = os.release(); |
Contributor
There was a problem hiding this comment.
Is there a reason not to do this on linux? I just tried on one of my codespaces and I get:
Welcome to Node.js v14.17.6.
Type ".help" for more information.
> require('os').release()
'5.4.0-1069-azure'
It's not in x.y.z form, but it's still valid. I think it's the kernel version.
Contributor
Author
There was a problem hiding this comment.
There are a few reasons.
- We want to limit the cardinality of the status values reported, and there are many more variations for Linux kernel release strings than for Windows and macOS release versions.
- Linux kernel release IDs may contain custom strings, and we want to avoid recording private data (for custom kernel builds on self-hosted runners, for example).
- Windows and macOS release strings are more useful because they are representative of the entire system configuration (whether you are running Windows 10 or Windows 11, for example). Linux kernel versions are less coupled with the userspace environment—5.11.3 on RedHat could be very different from 5.11.3 on Ubuntu.
So we are recording OS releases only for Windows and macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
This PR adds the OS and architecture (as reported by the GitHub Action Runner environments
RUNNER_OSandRUNNER_ARCH) to the status report.