C++/C#: Fix sync config file for value numbering sharing#2839
Merged
jbj merged 4 commits intogithub:masterfrom Feb 19, 2020
Merged
C++/C#: Fix sync config file for value numbering sharing#2839jbj merged 4 commits intogithub:masterfrom
jbj merged 4 commits intogithub:masterfrom
Conversation
Contributor
|
Note that this will have a sync conflict with #2835 |
e6ab99e to
98db6d8
Compare
jbj
reviewed
Feb 14, 2020
Contributor
jbj
left a comment
There was a problem hiding this comment.
Let's postpone merging this until we've merged the release-critical ValueNumbering fixes that are in conflict with this PR.
calumgrant
approved these changes
Feb 19, 2020
Contributor
calumgrant
left a comment
There was a problem hiding this comment.
LGTM as far as I can tell. Syncing these files certainly makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
identical-files.jsonfile was not specifying thatValueNumberingInternal.qllfiles should be shared between C# and C++.