Beginnings of multi repo PR support by dsyme · Pull Request #18599 · github/gh-aw

dsyme · 2026-02-27T00:59:32Z

Investigate CI failure in safe_outputs_handlers.test.cjs
Fix failing test: update assertion from "not found" to "not in the allowed-repos list" since the allowed-repos validation now runs before workspace checkout validation
Remove stale details field assertions that no longer apply to the allowed-repos error path
Verify test passes locally
Fix checkoutRepo() slug validation to reject slugs with more than one slash (e.g., owner/repo/extra) by enforcing parts.length === 2
Add test case for extra-slash slug rejection in dynamic_checkout.test.cjs
Use repoResult.repo (validated/qualified slug) instead of entry.repo.trim() for findRepoCheckout and patchOptions.repoSlug in safe_outputs_handlers.cjs
Rename test from "non-existent checkout" to "not in the allowed-repos list" to accurately describe what is tested

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Changeset

Type: patch
Description: Strengthened multi-repo checkout validation by normalizing repo slugs in the safe-output handlers, ensuring the allowed-repos error path is covered, and rejecting slugs with extra slashes.

Generated by Changeset Generator for issue #18599

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

✨ PR Review Safe Output Test - Run 22551448932

💥 [THE END] — Illustrated by Smoke Claude

kdehl16-web · 2026-02-27T06:02:45Z

Please work it

kdehl16-web · 2026-02-27T06:03:15Z

Fix the failed workflows (maybe in next commit)

kdehl16-web

Why...

kdehl16-web · 2026-02-28T19:01:57Z

Pls fix conflicts

actions/setup/js/dynamic_checkout.cjs

github-actions · 2026-03-01T14:53:23Z

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

github-actions · 2026-03-01T17:08:55Z

Hey @dsyme 👋 — great start on multi-repo PR support! The implementation looks well-structured: adding the repo field to the create_pull_request tool schema, tightening checkoutRepo() slug validation, and recompiling all 30+ lock files is a coherent, focused set of changes. Tests are present too — appreciated.

A couple of things worth tidying before this is ready for review:

Add a PR description — the body is currently an agent task log (completed checklist items), not an explanation of the feature. Reviewers need to understand what multi-repo PR support is, why it's needed, and what design decisions were made. A brief description covering the motivation, the key changes in safe_outputs_handlers.cjs / safe_outputs_config_helpers.go, and any known limitations would go a long way.
Resolve the "Beginnings of" scope — the title signals this is partial work. Either clarify what's still outstanding (via a description or a follow-up issue) or rename the PR to reflect exactly what is complete and merge-ready. The mergeable_state: blocked suggests CI is also still failing.

If you'd like a hand polishing this up, you can assign the following prompt to your coding agent:

For PR #18599 ("Beginnings of multi repo PR support") in github/gh-aw:

1. Write a proper PR description (replacing the agent task log in the PR body) that covers:
   - What multi-repo PR support is and why it is needed.
   - The key implementation changes: the new `repo` field added to the `create_pull_request` tool schema, the slug validation fix in `checkoutRepo()`, the use of `repoResult.repo` instead of `entry.repo.trim()` in `safe_outputs_handlers.cjs`, and the lock file recompile.
   - Any known limitations or follow-up work implied by the "Beginnings of" title.

2. Investigate and fix the current CI failure (mergeable_state is blocked). Run `make agent-finish` and ensure all checks pass.

3. Update the PR title to remove "Beginnings of" if the implementation is complete, or open a follow-up issue capturing remaining work so this PR can be merged as a self-contained increment.

Generated by Contribution Check

github-actions · 2026-03-01T20:02:40Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-03-01T20:02:43Z

🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...

github-actions · 2026-03-01T20:02:44Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-03-01T20:05:41Z

Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.53.0
jq	✅	1.7
yq	✅	4.52.4
curl	✅	8.5.0
gh	✅	2.87.3
node	✅	20.20.0
python3	✅	3.12.3
go	✅	1.24.13
java	✅	21.0.10
dotnet	✅	10.0.102

Result: 12/12 tools available ✅

Overall Status: PASS

🔧 Tool validation by Agent Container Smoke Test

github-actions · 2026-03-01T20:06:19Z

Commit pushed: 194e851

Generated by Changeset Generator

github-actions · 2026-03-01T20:08:16Z

🤖 Smoke test results for @dsyme's PR:

Test	Status
GitHub MCP	✅
Safe Inputs GH CLI	✅
Serena MCP	❌ (not available)
Playwright	✅
Web Fetch	✅
File Writing	✅
Bash	✅
Discussion Interaction	✅
Build gh-aw	✅
Discussion Creation	✅
Workflow Dispatch	✅
PR Review	✅

Overall: ⚠️ PARTIAL PASS (Serena MCP unavailable)

📰 BREAKING: Report filed by Smoke Copilot

github-actions

This PR adds a repo parameter to create_pull_request and other safe-output tools across lock files. The changes are consistent and well-described. Tests correctly reflect the updated behavior where create_pull_request always includes the repo field (from the base schema). LGTM.

📰 BREAKING: Report filed by Smoke Copilot

.github/workflows/ci-coach.lock.yml

github-actions · 2026-03-01T20:08:18Z

pkg/workflow/safe_outputs_tools_test.go

 			toolName:   "create_pull_request",
-			expectRepo: false,
+			expectRepo: true,
 		},


The test cases correctly cover the updated behavior: create_pull_request always has a repo parameter (since it's in the base schema), and the description text is now more precise. The table-driven test structure is clean and easy to follow.

github-actions · 2026-03-01T20:08:32Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-03-01T20:12:46Z

Smoke Test Results — Run §22551448932

Core tests #1–10: ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅
PR review tests #11–17: ✅ ✅ ✅ ✅ ✅ ✅ ⚠️

Overall: PARTIAL (16 passed, 1 skipped — no safe PR to close for #17)

💥 [THE END] — Illustrated by Smoke Claude

github-actions

💥 Automated smoke test review - all systems nominal!

💥 [THE END] — Illustrated by Smoke Claude

kdehl16-web · 2026-03-02T01:33:38Z

Stop deleting my comments

dsyme added 4 commits February 27, 2026 00:58

multi repo

25079bf

multi-repo

3fa8a65

multi-repo

d078670

get tests passing

10f5a05

github-actions bot added the needs-work label Feb 27, 2026

github-actions bot mentioned this pull request Feb 27, 2026

[Contribution Check Report] Contribution Check — 2026-02-27 #18611

Closed

missing file

9e6fc07

github deleted a comment from github-actions bot Feb 27, 2026

dsyme added 3 commits February 27, 2026 02:35

missing file

770950a

fix build

ef29f65

fix build

5ad9c7b

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Feb 27, 2026

[Contribution Check Report] Contribution Check — 2026-02-27 #18633

Closed

kdehl16-web reviewed Feb 27, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

This was referenced Feb 27, 2026

[Contribution Check Report] Contribution Check — 2026-02-27 #18655

Closed

[Daily Report] Daily Status Report — 2026-02-27 #18656

Open

[aw] No-Op Runs #18652

Closed

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Feb 27, 2026

[Contribution Check Report] Contribution Check — 2026-02-27 #18690

Closed

dsyme added 3 commits February 27, 2026 18:10

Merge branch 'main' of https://github.com/github/gh-aw into mrp

582b6a9

fix error message

2ee6cd2

Merge branch 'main' of https://github.com/github/gh-aw into mrp

545aa45

fix test

cc0e02b

dsyme commented Mar 1, 2026

View reviewed changes

actions/setup/js/dynamic_checkout.cjs Show resolved Hide resolved

Copilot started work on behalf of dsyme March 1, 2026 02:14 View session

github-actions bot mentioned this pull request Mar 1, 2026

[Contribution Check Report] Contribution Check — 2026-03-01 #19087

Closed

dsyme added 2 commits March 1, 2026 19:52

fix dependency

9b15eb9

add test

b681d5a

github deleted a comment from kdehl16-web Mar 1, 2026

add test

d1ce5d3

dsyme added smoke and removed smoke needs-work labels Mar 1, 2026

Add changeset [skip-ci]

194e851

ci: trigger CI checks

487c835

github-actions bot mentioned this pull request Mar 1, 2026

Smoke Test: Copilot - 22551448922 #19108

Closed

github-actions bot added smoke-copilot and removed smoke labels Mar 1, 2026

github-actions bot reviewed Mar 1, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 1, 2026

Smoke Test: Claude - 22551448932 #19109

Closed

github-actions bot added the smoke-claude label Mar 1, 2026

github-actions bot reviewed Mar 1, 2026

View reviewed changes

dsyme merged commit 0d40e9c into main Mar 1, 2026
49 checks passed

dsyme deleted the mrp branch March 1, 2026 20:24

Conversation

dsyme commented Feb 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset

Uh oh!

This comment has been minimized.

This comment has been minimized.

kdehl16-web commented Feb 27, 2026

Uh oh!

kdehl16-web commented Feb 27, 2026

Uh oh!

kdehl16-web left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

kdehl16-web commented Feb 28, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot commented Mar 1, 2026

Agent Container Tool Check

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kdehl16-web commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dsyme commented Feb 27, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Mar 1, 2026 •

edited

Loading

github-actions bot commented Mar 1, 2026 •

edited

Loading