[log] Add debug logging to 5 pkg/ files#19455
Merged
Conversation
- workflow/agent_validation: log max-turns, max-continuations, and web-search feature validation with engine ID and config details - workflow/compiler_safe_outputs_core: log custom-token detection and base config collection results (logger was declared but unused) - cli/trial_repository: log repository lifecycle operations including cleanup, clone, write, modify, and commit/push steps - cli/generate_action_metadata_command: log file processing loop progress and per-action yml/README generation - parser/import_field_extractor: log field extraction entry with content size, engine config detection, and final result summary Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds meaningful debug logging to 5 Go files that were missing log calls or had declared loggers that were never used.
Files changed
pkg/workflow/agent_validation.go— Added logging tovalidateMaxTurnsSupport,validateMaxContinuationsSupport, andvalidateWebSearchSupportto trace feature compatibility checks with engine ID and config values.pkg/workflow/compiler_safe_outputs_core.go— Added logging tohasCustomTokenSafeOutputsandcollectBaseSafeOutputConfigs. TheconsolidatedSafeOutputsLogvariable was declared but never used.pkg/cli/trial_repository.go— Added logging tocleanupTrialRepository,cloneTrialHostRepository,writeWorkflowToTrialDir, andmodifyWorkflowForTrialModeto trace repository lifecycle operations during trial mode.pkg/cli/generate_action_metadata_command.go— Added logging to the file processing loop inGenerateActionMetadataCommand, and togenerateActionYmlandgenerateReadmeto surface per-action generation progress.pkg/parser/import_field_extractor.go— Added logging at function entry with content size, engine config detection, and finalImportsResultsummary intoImportsResult.Test plan
make buildpasses with no compilation errorsgo vet ./pkg/workflow/... ./pkg/parser/... ./pkg/cli/...passes with no issuesDEBUG=workflow:agent_validationetc.🤖 Generated with [Claude Code]((claude.com/redacted)