chore: Pin eslint to 9.39.3 (eslint@10 incompatible with eslint-plugin-github)#194
Merged
abdulahmad307 merged 2 commits intodependabot/npm_and_yarn/eslint-10.0.2from Mar 5, 2026
Merged
Conversation
…ithub Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Bump eslint from 9.39.2 to 10.0.2
chore: Pin eslint to 9.39.3 (eslint@10 incompatible with eslint-plugin-github)
Mar 4, 2026
a1b2fe1
into
dependabot/npm_and_yarn/eslint-10.0.2
2 of 3 checks passed
There was a problem hiding this comment.
Pull request overview
Pins ESLint to a compatible 9.x version to avoid peer dependency conflicts and runtime breakage with eslint-plugin-github@6.0.0.
Changes:
- Downgrades ESLint from
^10.0.2to^9.39.3inpackage.json - Updates the lockfile to reflect the ESLint downgrade
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "devDependencies": { | ||
| "eslint": "^10.0.2", | ||
| "eslint": "^9.39.3", |
There was a problem hiding this comment.
The PR title says "Pin eslint to 9.39.3", but ^9.39.3 is not a pin—it allows automatic upgrades up to (but not including) 10.0.0. If the intent is a true pin to avoid future incompatibilities, change this to "eslint": "9.39.3" (or use ~9.39.3 if you only want patch updates).
Suggested change
| "eslint": "^9.39.3", | |
| "eslint": "9.39.3", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint 10 cannot be used with
eslint-plugin-github@6.0.0for two reasons:eslint-plugin-github@6.0.0declarespeerDependencies: { eslint: "^8 || ^9" }— no released version supports eslint@10context.getSourceCode(), whicheslint-plugin-eslint-comments(transitive dep viaeslint-plugin-github) still callsChanges
eslintfrom^10.0.2→^9.39.3(latest 9.x) inpackage.jsonpackage-lock.jsonaccordingly💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.