Strip usernames from URLs as well as passwords#1437
Merged
Byron merged 1 commit intogitpython-developers:mainfrom May 5, 2022
glennmatthews:issue-1284
Merged
Strip usernames from URLs as well as passwords#1437Byron merged 1 commit intogitpython-developers:mainfrom glennmatthews:issue-1284
Byron merged 1 commit intogitpython-developers:mainfrom
glennmatthews:issue-1284
Conversation
Member
|
Thanks a lot for your contribution! I particularly like that there are tests for all changes (which I assume break without these modifications). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1284
remove_password_if_presentto remove usernames from URLs as well as the existing behavior of removing passwords from URLs.CommandError.__init__to also callremove_password_if_presentjust in case an exception gets raised from a non-sanitized command by mistake.