Fix traceback because _seen_ops is not initialised#451
Merged
Byron merged 1 commit intogitpython-developers:masterfrom May 29, 2016
barry-scott:pr-fix-callable-remote-progress
Merged
Fix traceback because _seen_ops is not initialised#451Byron merged 1 commit intogitpython-developers:masterfrom barry-scott:pr-fix-callable-remote-progress
Byron merged 1 commit intogitpython-developers:masterfrom
barry-scott:pr-fix-callable-remote-progress
Conversation
must call the base class __init__
Member
|
Argh, thanks ! That code is not called by the test-suite yet :( . |
Byron
added a commit
that referenced
this pull request
May 29, 2016
Related to #451 Signed-off-by: Sebastian Thiel <byronimo@gmail.com>
| def __init__(self, fn): | ||
| self._callable = fn | ||
|
|
||
| RemoteProgress.__init__(self) |
Contributor
There was a problem hiding this comment.
This should be super(CallableRemoteProgress, self).__init__() instead.
Contributor
|
Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
must call the base class init