Merged
Conversation
The diff --patch parser was missing some edge case where Git would
encode non-ASCII chars in path names as octals, but these weren't
decoded properly.
\360\237\222\251.txt
Decoded via utf-8, that will return:
💩.txt
cc1c258 to
1faf84f
Compare
Contributor
Author
|
@Byron This is a bug we've seen in production for some time now. Happy for me to release 2.0.4 with this fix right now? |
Member
|
No objections, please feel free to make a release. In any case, thanks for your contribution :) ! |
Contributor
Author
|
Sure, will do! |
Contributor
Author
|
2.0.4 is now up on PyPI :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff
--patchoutput parser was missing some edge case where Git would encode non-ASCII chars in path names as octals, but these weren't decoded properly.Decoded via utf-8, that will return: