Add missing RID cleanup in server examples#11750
Open
Calfur wants to merge 2 commits intogodotengine:masterfrom
Open
Add missing RID cleanup in server examples#11750Calfur wants to merge 2 commits intogodotengine:masterfrom
Calfur wants to merge 2 commits intogodotengine:masterfrom
Conversation
- Adds cleanup of manually created `RID`s in GDScript (`_exit_tree()`). - Adds cleanup of manually created `Rid`s in C# (`_ExitTree()`). ## Why As memory management does not occur automatically when using RenderingServer directly, it is recommended to implement manual cleanup. I think it makes sense to do so in the example in the docs as well, as this is not shown on the page yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RIDs in GDScript.Rids in C#.Why
As memory management does not occur automatically when using RenderingServer directly, it is recommended to implement manual cleanup.
I think it makes sense to do so in the example in the docs as well, as this is not shown on the page yet.