Refactor sanitize_token for better subclassing #26
Closed
mfa wants to merge 3 commits intohtml5lib:masterfrom
Closed
Refactor sanitize_token for better subclassing #26mfa wants to merge 3 commits intohtml5lib:masterfrom
mfa wants to merge 3 commits intohtml5lib:masterfrom
Conversation
…tizerMixin for usage in subclass.
Member
|
Well, Travis CI shows you having made all the sanitizer tests fail. That ought to be fixed. Otherwise, you should use the standard English "disallow" and not "unallow". That said, in principle looks good. |
Member
|
Merged in 52f9ca6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my application I need to clean all unallowed tokens.
At the moment the only way is to copy the whole sanitize_token method, remove a few lines and add one.
Splitting up the sanitize_token method would simplify this a lot and reduces code duplication (in my code).
Example usage: