streams: openssl: Handle error in SSL_CTX_new#4701
Merged
pks-t merged 1 commit intolibgit2:masterfrom Jun 29, 2018
Merged
Conversation
SIGSEGV otherwise...
Member
|
Thanks for your fix! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGSEGV otherwise...
I saw the segfault on Fedora when using libgit2 with nodegit. The segfault was in in SSL_CTX_set_verify because it was the first function that tried to actually write to the NULL pointer.