config_file: check result of git_array_alloc#5053
Merged
ethomson merged 1 commit intolibgit2:masterfrom Apr 16, 2019
tniessen:cf-check-array-alloc-result
Merged
config_file: check result of git_array_alloc#5053ethomson merged 1 commit intolibgit2:masterfrom tniessen:cf-check-array-alloc-result
ethomson merged 1 commit intolibgit2:masterfrom
tniessen:cf-check-array-alloc-result
Conversation
git_array_alloc can return NULL if no memory is available, causing a segmentation fault in memset. This adds GIT_ERROR_CHECK_ALLOC similar to how other parts of the code base deal with the return value of git_array_alloc.
Member
|
This is a good catch. Thanks, @tniessen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git_array_alloccan returnNULLif no memory is available, causing a segmentation fault in memset. This addsGIT_ERROR_CHECK_ALLOCsimilar to how other parts of the code base deal with the return value ofgit_array_alloc.This is my first contribution to libgit2, please let me know if I made a mistake.